Wrap writing events in a lock to avoid race condition#3
Merged
prochnowc merged 1 commit intoAppCoreNet:mainfrom Dec 20, 2024
Merged
Wrap writing events in a lock to avoid race condition#3prochnowc merged 1 commit intoAppCoreNet:mainfrom
prochnowc merged 1 commit intoAppCoreNet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If multiple threads, or multiple instance of the application attempt to write events to the event store at the same time, it can cause some events to be skipped. For example:
(this will be higher than the ID that Writer 1 wrote)
The event from Writer 1 will never be processed as its ID is lower than the one that was already processed from Writer 2.
Therefore, we need to ensure that the events are committed in the same order as the IDs are allocated. We cannot perform this locking on the .NET side as there may be multiple instances of the application.